Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass NEUTRON_KUTTL_DIR to kuttl neutron env #915

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pass NEUTRON_KUTTL_DIR to kuttl neutron env #915

wants to merge 1 commit into from

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Sep 24, 2024

The variable is now used by one of the tests that was recently added to main with:

openstack-k8s-operators/neutron-operator#406

Without setting the variable, the test fails to execute the script and fails.

Related: https://issues.redhat.com//browse/OSPRH-4296

@booxter
Pass NEUTRON_KUTTL_DIR to kuttl neutron env
ae49608 
The variable is now used by one of the tests that was recently added to
main with:

openstack-k8s-operators/neutron-operator#406

Without setting the variable, the test fails to execute the script and
fails.

Related: https://issues.redhat.com//browse/OSPRH-4296
@openshift-ci openshift-ci bot requested review from fao89 and viroel September 24, 2024 21:10
@booxter
Copy link
Contributor Author

booxter commented Sep 24, 2024

@karelyatin FYI

@booxter booxter requested a review from karelyatin September 24, 2024 21:10
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2a0540c3d43043e98bb2be91f3079762

❌ openstack-k8s-operators-content-provider FAILURE in 6m 44s
⚠️ install-yamls-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@booxter
Copy link
Contributor Author

booxter commented Sep 25, 2024

recheck

fao89
fao89 reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@fao89 fao89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: booxter, fao89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fao89 fao89 fao89 left review comments

@viroel viroel Awaiting requested review from viroel

@karelyatin karelyatin Awaiting requested review from karelyatin

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@booxter @fao89